Feeling Lucky
[#193] - JController::factory() and createEnvironmentArray() as discussed in joomla-dev-cms group
- Closed
- 3 Oct 2013
- Medium
- Build: master
- # 193
- Diff
- dgasparri:9fbbf63da6755b32c9bb1a7325e7c3747d92e379
User tests: Successful: Unsuccessful:
Added to JController the following methods:
- factory()
- createEnvironmentArray()
- setTask($task)
Changed execute($task) that if no task is passed, it executes the
$this->task (which is set also by the factory method)
See discussion https://groups.google.com/forum/?fromgroups#!topic/joomla-dev-cms/7tjVkzc08Ks (Object oriented components , any plan?)
2012-04-19 by Duccio Gasparri duccio.gasparri@gmail.com
Change-Id: I2a4ded062856670e364128f3cb74716b84b23eea
dgasparri
- comment
- 22 Apr 2012
coolbung
- 
phproberto
- comment
- 3 Oct 2013
I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged.
Thanks for contributing.
getInstance() should also be cleaned and simplified, as it does stuff proper of a factory pattern and factory method (choosing which class to load). Not knowing if there was backward compatibility issues, I left it like that.
Part of the "reasoning" in getInstance() about the environment variables ($_REQUEST task, controller, option, and so on) are left intact in the getInstance(), but were duplicated cleared and streamlined into the createEnvironmentArray() method.