? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
4 Jan 2018

Pull Request for Issue # .

Summary of Changes

Switch to the namespaced classes

Simple code review should be sufficient here

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar dgt41 dgt41 - open - 4 Jan 2018
avatar dgt41 dgt41 - change - 4 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2018
Category Libraries
avatar Anu1601CS
Anu1601CS - comment - 5 Jan 2018

@dgt41 can we use Joomla\CMS\Authentication\Authentication; namespaced for Authentication
Currently, I am updating namespaced in plugins. So, I am little bit confused.

avatar C-Lodder
C-Lodder - comment - 5 Jan 2018

@Anu1601CS - Look at this file which will help libraries/classmap.php

JAuthentication >> Joomla\CMS\Authentication\Authentication

avatar Anu1601CS
Anu1601CS - comment - 5 Jan 2018

Thanks

avatar dgt41 dgt41 - change - 28 Jan 2018
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 21 May 2018

@laoneo this one can be merged on review

avatar laoneo
laoneo - comment - 22 May 2018

Drone fails and there are some requests open. Can you fix them please.

avatar infograf768
infograf768 - comment - 22 May 2018

@laoneo
Looks like drone fails everywhere this morning.

avatar dgrammatiko
dgrammatiko - comment - 22 May 2018

I did the requested changes but the Drone part is failing at installation, no clue what's wrong without viewing the saved image

avatar laoneo
laoneo - comment - 22 May 2018

Can you install joomla with your pr branch?

avatar dgrammatiko
dgrammatiko - comment - 22 May 2018

Yup, works here: screen shot 2018-05-22 at 17 46 40

EDIT: So the branch is failing here as well

54f6493 22 May 2018 avatar dgrammatiko o_o
avatar dgrammatiko
dgrammatiko - comment - 22 May 2018

@laoneo now should be fine

avatar laoneo laoneo - change - 23 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-23 04:41:53
Closed_By laoneo
avatar laoneo laoneo - close - 23 May 2018
avatar laoneo laoneo - merge - 23 May 2018

Add a Comment

Login with GitHub to post a comment