Joomla! Issue Tracker | Joomla! CMS #19283 - additional complex value test

? ?

Fixed in Code Base
15 Jan 2018
Medium
Build: staging
# 19283
Diff
stutteringp0et:patch-10

Pending

Related to # 19025

User tests: Successful: Unsuccessful:

stutteringp0et
4 Jan 2018

in my test case, I neglected to test for a single dimension array with non-numeric keys (a complex field, with a simple dataset) This test excluded the normal arrays (multiselects and checkboxes) while identifying complex datasets by examining the array keys.

The test is now an array which has a normal count that does not match the recursive count (multidimensional) OR an array with non-numeric keys.

Pull Request for Issue # .

Summary of Changes

numeric key test added to complex value test

Testing Instructions

email me for a test plugin michael at richeyweb.com

Expected result

after this modification, non-repeating fields behave normally

Actual result

Documentation Changes Required

none

Votes

# of Users Experiencing Issue

0/1

Average Importance Score

5.00

5e16e3e 4 Jan 2018

additional complex value test

stutteringp0et - open - 4 Jan 2018

stutteringp0et - change - 4 Jan 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 4 Jan 2018

Category

⇒

Front End Plugins

cfd4e41 4 Jan 2018

code style

stutteringp0et - change - 4 Jan 2018

Labels

Added: ?

stutteringp0et - comment - 5 Jan 2018

Something is wrong with Travis CI PHP5.5: [RuntimeException] Failed to clone...

Quy - test_item - 13 Jan 2018 - Tested successfully

Quy - comment - 13 Jan 2018

I have tested this item ✅ successfully on cfd4e41

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Quy - change - 13 Jan 2018

Rel_Number	0	⇒	19025
Relation Type		⇒	Related to

Quy - comment - 13 Jan 2018

@Joomill Please test with Multiple set to false. Thanks. Related to #19025.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Joomill - comment - 14 Jan 2018

@stutteringp0et i have your subform plugin version 1.3
Do you have a later version or can i use this one?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Quy - comment - 14 Jan 2018

@Joomill I asked the same question and was told to use the plugin v1.3 to test.

Joomill - test_item - 14 Jan 2018 - Not tested

Joomill - comment - 14 Jan 2018

I have not tested this item.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Joomill - comment - 14 Jan 2018

I have not tested this item.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Joomill - test_item - 14 Jan 2018 - Not tested

Joomill - comment - 14 Jan 2018

I have tested this item ✅ successfully on cfd4e41

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19283.}

Joomill - test_item - 14 Jan 2018 - Tested successfully

franz-wohlkoenig - change - 14 Jan 2018

Status

Pending

⇒

Ready to Commit

franz-wohlkoenig - comment - 14 Jan 2018

Ready to Commit after two successful tests.

stutteringp0et - comment - 15 Jan 2018

Thank you again, gentlemen!

mbabker - change - 15 Jan 2018

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2018-01-15 15:04:10
Closed_By		⇒	mbabker
Labels	Added: ?

mbabker - close - 15 Jan 2018

mbabker - merge - 15 Jan 2018

Add a Comment

Login with GitHub to post a comment

Older
Newer