[#19273] - [4.0] Fix filename not displaying properly in media manager.
- Closed
- 3 Jan 2018
- Medium
- Build: 4.0-dev
- # 19273
- Diff
- Anu1601CS:4.0-dev
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
###Issue
File and folder name not displaying properly.
The file path is showing in the place of the filename.
Summary of Changes
Changes in:
plugins/filesystem/local/Adapter/LocalAdapter.php
Testing Instructions
Open media manager and check out.
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@franz-wohlkoenig but I am getting this issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19273.
It is an issue on Windows, I can confirm it. Haven't looked at the code yet but maybe you should make PR on this repo https://github.com/joomla-projects/media-manager-improvement
@joomdonation yes, I am using windows.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19273.
ok, I am going to make PR to media-manager-improvement
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19273.
Without testing much, I think proper fix would be change code to:
private function getFileName($path)
{
$path = \JPath::clean($path);
// Basename does not work here as it strips out certain characters like upper case umlaut u
$path = explode(DIRECTORY_SEPARATOR, $path);
// Return the last element
return array_pop($path);
}It should work on both Windows and Linux
@joomdonation Yes this one is a proper fix for this issue thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19273.
Should I make a PR to media-manager-improvement with these changes?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19273.
I think so. Look like media manager is still being developed on it own repo, so better make PR on https://github.com/joomla-projects/media-manager-improvement
@joomdonation Thanks
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-03 13:14:55 |
| Closed_By | ⇒ | Anu1601CS | |
| Labels |
Added:
?
|
||
Without Pull Request have no Issue:
System information
4.0-dev
Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2