Feeling Lucky
?
[#19271] - [Modern Routing] make a simpler loop in StandardRules::build
- Fixed in Code Base
- 13 Feb 2018
- Medium
- Build: staging
- # 19271
- Diff
- csthomas:make_simpler_standard_rule_build_v2
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Replace the old complex loop with a simpler one
Everything should work as before.
This is a copy of #19012 without an additional improvement in order to be more B/C.
Testing Instructions
Code review.
Additional test if SEF URLs work as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
joomdonation
- comment
- 3 Jan 2018
OK Tomasz. Still busy with some support stuffs right now, so I will review + test it on tomorrow
joomdonation
- comment
- 4 Jan 2018
I have tested this item
Code review + test with sample data + test with custom setup for com_content. All still works OK as before and the new code is easier to understand compare to the original code
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19271.
Anu1601CS
- comment
- 25 Jan 2018
I have tested this item
Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19271.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 25 Jan 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19271.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-13 00:07:22 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@joomdonation I have moved
isset($item->query['view'])to the top of method and I removed the$last_idas you requested.