[#1925] - Amazon S3 and Rackspace packages
- Closed
- 15 Apr 2015
- Medium
- Build: master
- # 1925
- Diff
- alexukf:gsoc-cloud-storage
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
For the GSoC cloud storage project
Awesome!
I did some refactoring to both of these packages:
- Throwed exceptions in fail conditions.
- Created a new method for handling response codes and headers and removed some duplicate code.
- Replaced JAmazons3Http with JHttp and removed the corresponding test.
One Travis job failed a test (out of many with a very similar behavior) which calculates a signature based on a date. The problem is that the test and the actual method were run at different seconds:
'Date' => 'Thu, 19 Sep 2013 13:16:58 +0000'
'Date' => 'Thu, 19 Sep 2013 13:16:59 +0000'
This is a pretty unlikely situation, but it may happen once in a while. I cannot replace the call to date("D, d M Y H:i:s O") in the test with a fixed string, because the calculated signature will not match the one in the tested method. Should I leave these kind of tests here or should I remove them?
The authorization is tested separately in the JAmazons3ObjectTest class, so I have removed it from the other test classes.
brianteeman
- | Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | Libraries |
Thank you for your contribution but the PLT has decided it is not fit for the Joomla core. We do think it might be useful for the framework or as a standalone package. You could pursue that direction.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-15 20:17:48 |
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31972&start=0 clou