? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Dec 2017

We have a complete mix of using the word show in our option strings
For example we have
Show Option - yes/no
Show Option - show/hide
Option - show/hide

This is a first pass at making them consistently
Option - show/hide

To test/review its easiest to select a components options and then use the sidebar to move between components

If approved then I will do further PR to address this inconsistency in the UI everywhere

dd6cffb 31 Dec 2017 avatar brianteeman more
avatar brianteeman brianteeman - open - 31 Dec 2017
avatar brianteeman brianteeman - change - 31 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2017
Category Administration com_config com_content com_finder com_menus com_users Language & Strings Front End
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Dec 2017
Title
[4.0]Show hide strings
[4.0] Show hide strings
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Jan 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jan 2018

I have tested this item successfully on dd6cffb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19242.

avatar wilsonge
wilsonge - comment - 2 Jan 2018

I think this makes lots of sense

avatar brianteeman
brianteeman - comment - 2 Jan 2018

@wilsonge should i add the rest to this PR or in another PR?

avatar wilsonge
wilsonge - comment - 2 Jan 2018

If you're ok with it add the rest to this PR and ping me when you're done and I'll get it merged

avatar brianteeman
brianteeman - comment - 2 Jan 2018

ok

avatar brianteeman brianteeman - change - 2 Jan 2018
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2018
Category Administration com_config com_content com_finder com_menus com_users Language & Strings Front End Administration com_config com_content com_finder com_menus com_users Language & Strings Modules Front End
avatar brianteeman
brianteeman - comment - 2 Jan 2018

@wilsonge I finished with this

avatar wilsonge wilsonge - change - 3 Jan 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-03 23:56:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Jan 2018
avatar wilsonge wilsonge - merge - 3 Jan 2018
avatar wilsonge
wilsonge - comment - 3 Jan 2018

@Quy do you want to do a PR addressing the consistency issues you raised :)

avatar brianteeman
brianteeman - comment - 4 Jan 2018

Thanks kindly

avatar wilsonge
wilsonge - comment - 4 Jan 2018

Thanks!

Add a Comment

Login with GitHub to post a comment