[#19220] - [4.0] Versions broken on frontend
- Closed
- 29 Dec 2017
- Medium
- Build: 4.0-dev
- # 19220
Steps to reproduce the issue
4.0-dev install
install sample data
edit one on the frontend
click versions button
Expected result
modal with versions
Actual result
[Fri Dec 29 18:02:14 2017] 127.0.0.1:65513 [500]: /index.php/index.php?option=com_contenthistory&view=history&layout=modal&tmpl=component&field=jform_contenthistory&item_id=1&type_id=1&type_alias=com_content.article&4b3fc97cd85b077325bbf9e3c606f92f=1
page reloads
This is because in HTML5 the default action for a button is to SUBMIT the form, you need type="button" attribute to stop that happening...
Note also that the button has a jQuery('#versionsModal').modal('show') onclick action - I thought the frontend was getting rid of all jQuery in favor of "JS"?
However after adding that, the modal now correctly shows - but the iframe inside it incorrectly loads:
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | com_content Front End |
| Status | New | ⇒ | Confirmed |
PR incoming for the button
The other error is
0 Invalid controller class: Joomla\Component\Contenthistory\Site\Controller\DisplayController
| Build | staging | ⇒ | 4.0-dev |
#18679 would not fix the popup button - that needs @brianteeman's upcoming PR :)
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-29 18:17:41 |
| Closed_By | ⇒ | brianteeman |
That's why I quoted the error message
ZZZzzzz.....
Issue confirmed, on following Setting Modal open an close at same Time:
System information
4.0.0-dev
Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19220.