Feeling Lucky
?
?
[#19201] - [CS] New round of Code Style fixes for components/
- Fixed in Code Base
- 8 Jan 2018
- Medium
- Build: staging
- # 19201
- Diff
- photodude:PHPCS2-Components3
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Space before opening parenthesis of function call prohibited
- Space after opening parenthesis of function call prohibited
- Block comment text must start on a new line
- Multi-line function call not indented correctly
- preference blockComment style over multiple single line comments
- arrays should end with a comma
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
Some manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_finder com_mailto com_users |
| Labels |
Added:
?
|
||
Quy
- comment
- 28 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19201.
csthomas
- comment
- 28 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19201.
| Status | Pending | ⇒ | Ready to Commit |
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-08 17:11:49 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 80e5394
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19201.