Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19197] - Set active class in mod_articles_categories when SEF is off

? ? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
28 Dec 2017

Pull Request for Issue #19194 .

Summary of Changes

Do not replace & by & in URL in JRoute::_(...) when comparing to $_SERVER['REQUEST_URI']

Testing Instructions

Test issue #19194

Expected result

When SEF is off.
Active class will appear when we are on the category page.

Actual result

When SEF is off active class in (<li class="active">) is missing.

Documentation Changes Required

None

avatar csthomas csthomas - open - 28 Dec 2017
avatar csthomas csthomas - change - 28 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2017
Category ⇒ Modules Front End
avatar joomdonation
joomdonation - comment - 28 Dec 2017

How do you think about using code like this:

  1. Add the code to get necessary variables from input at the beginning of file:
$input  = JFactory::getApplication()->input;
$option = $input->getCmd('option');
$view   = $input->getCmd('view');
$id     = $input->getInt('id');
  1. And then change if command to:
if ($option == 'com_content' && $view == 'category' && $id == $item->id) echo ' class="active"';
avatar csthomas csthomas - change - 28 Dec 2017
Labels Added: ?
avatar csthomas
csthomas - comment - 28 Dec 2017

@joomdonation Your suggestion is good, thanks.

avatar joomdonation joomdonation - test_item - 28 Dec 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 28 Dec 2017

I have tested this item ✅ successfully on f4dce78

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19197.

avatar Quy Quy - test_item - 28 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 28 Dec 2017

I have tested this item ✅ successfully on fc0c98f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19197.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Dec 2017

@joomdonation can you please retest?

avatar Quy
Quy - comment - 28 Dec 2017

@franz-wohlkoenig It is only coding style to remove an extra space. It does not affect test result.

avatar joomdonation
joomdonation - comment - 28 Dec 2017

The last change is just code style, so my test is still success. You can mark this PR as RTC

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Dec 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 3 Jan 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-03 00:09:34
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Jan 2018
avatar mbabker mbabker - merge - 3 Jan 2018

Add a Comment

Login with GitHub to post a comment