Feeling Lucky
?
[#19193] - Fix warning on JHtmlMenu::treerecurse method on PHP 7.2
- Fixed in Code Base
- 3 Jan 2018
- Medium
- Build: staging
- # 19193
- Diff
- joomdonation:patch-9
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When method JHtmlMenu::treerecurse is used on PHP 7.2, there are some warnings like this displayed:
Warning: count(): Parameter must be an array or an object that implements Countable in D:\www\joomla\libraries\cms\html\menu.php on line 382
This PR just fixes it.
Testing Instructions
- You need to run your Joomla website on PHP 7.2
- Open the file templates/protostar/index.php, add this line of code:
echo JHtml::_('select.genericlist', JHtmlMenu::linkOptions(), 'link_option');- Access to frontend of the site, you will see many warning messages like this:
Warning: count(): Parameter must be an array or an object that implements Countable in D:\www\joomla\libraries\cms\html\menu.php on line 382
- Apply patch, the warnings are gone. You should see a dropdown contains menu items
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Quy
- comment
- 28 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19193.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Dec 2017
RTC
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-03 00:09:58 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on abd88cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19193.