[#19181] - Fix Help URLs and update to Help38
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19181
- Diff
- Quy:helpurl
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19149.
Summary of Changes
Remove ?amp; from Help URLs and update to Help38
Testing Instructions
Install PR.
Delete configuration.php.
Go to the front end to reinstall Joomla.
Install Test English (GB) Sample Data.
Go to front end.
Under All Modules, click Smart Search.
Click Help in the article.
Expected result
https://help.joomla.org/proxy/index.php?keyref=Help38:Extensions_Module_Manager_Smart_Search
Actual result
https://help.joomla.org/proxy/index.php?amp;keyref=Help31:Extensions_Module_Manager_Smart_Search
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql MS SQL Unit Tests |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
I have tested this item
Wrong Link stay: https://help.joomla.org/proxy/index.php?amp;keyref=Help31:Extensions_Module_Manager_Smart_Search
Uninstalling PR give:
System information
3.8.4-dev
Multilanguage Site (4 Lang.) & Test English (GB) Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2
- Apache-Server
- PHP 7.0.22
- MySQLi 5.6.35
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19181.
You will have to reinstall Joomla. Testing instructions updated.
I tested first in installed 3.8.4 and got wrong URL. Then i installed a fresh staging with same Result (wrong URL).
Please follow testing instructions.
Reinstall Joomla.
means "Joomla Update > Reinstall Joomla Core files"?
No. Once the configuration file is deleted, access the front end which will force an installation.
- patch installed
- configuration.php deleted
- copy "Installation"-Folder from downloaded staging to Joomla3-Folder
- open Frontend and reinstall Joomla
Same Result: Wrong Link https://help.joomla.org/proxy/index.php?amp;keyref=Help31:Extensions_Module_Manager_Smart_Search
copy "Installation"-Folder from downloaded staging to Joomla3-Folder
This is the part you're messing up. You need the installation folder from this PR, not from staging (staging has the bad URL, this PR has the good one).
Download the ZIP from https://github.com/Quy/joomla-cms/tree/helpurl and install that.
I have tested this item
Thanks for Help @Quy @mbabker
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19181.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19181.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:13:43 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
If your going to correct it then let's have the correct url with at least 38 not 31:)