[#19169] - [4.0] Fix Subhead buttons does not display properly on scroll.
- Closed
- 26 Dec 2017
- Medium
- Build: 4.0-dev
- # 19169
- Diff
- Anu1601CS:4.0-dev
User tests: Successful: Unsuccessful:
Issue
This issue present where subhead buttonis used. Subhead buttons do not display properly on a scroll. You can check any of them.
Like: Try to open page to write a new article then scroll down.
You can check save and cancel button, not align properly.
Summary of Changes
Changes in :
administrator/modules/mod_menu/tmpl/default.php
and
administrator/templates/atum/index.php
Adding of javascript file changed from default to index
Testing Instructions
Step1: Try to open page to write a new article then scroll down.
Expected result
Buttons Align properly
Actual result
Buttons not align properly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
@C-Lodder can you Test and review changes. Because this issue occurs after #19086 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.
Please dont do this. The script should be called from the module, not the template.
If there's a bug, I'll fix thr script
Could you let me know which browser you're using please?
@C-Lodder Google chrome
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.
Ok I'll test hopefully tomorrow.
@C-Lodder can we add
// Fix toolbar and footer width for edit views
if (wrapper.classList.contains('wrapper0')) {
if (subhead) {
subhead.style.left = 0;
}
if (status) {
status.style.marginLeft = 0;
}
}
to
system/js/toolbar.js
because this one is a part of templete.js
Thanks for review :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.
Yup dont worry. We're still in the process of removing the JS from template.js
ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.
| Labels |
Added:
?
|
||
| Category | Modules Administration Templates (admin) | ⇒ | Modules Administration |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-26 14:40:06 |
| Closed_By | ⇒ | Anu1601CS |
@Anu1601CS if you're about to do so please take a look at #17868
The point is that the menu javascript will eventually be implemented as a custom element, and also we need to make sure that it fulfils the accessibility requirements. Oh also we need to wait for the new design to be approved so we don't end up rewriting the same code too many times
@dgt41 Thanks for the information.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.
I have tested this item✅ successfully on c79ea07
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19169.