Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19160] - [CS] Code Style fixes for Valid Logical Operators

? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
24 Dec 2017

Pull Request for Issue use Valid Logical Operators

Summary of Changes

  • Logical operator and not allowed; use && instead
  • Logical operator or not allowed; use || instead

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

avatar photodude photodude - open - 24 Dec 2017
avatar photodude photodude - change - 24 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2017
Category ⇒ Front End com_contact Libraries
avatar Quy Quy - test_item - 24 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 24 Dec 2017

I have tested this item ✅ successfully on f981254

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19160.

avatar wilsonge wilsonge - change - 25 Dec 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-12-25 01:11:06
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Dec 2017
avatar wilsonge wilsonge - merge - 25 Dec 2017

Add a Comment

Login with GitHub to post a comment