Feeling Lucky
?
?
[#19148] - [4.0] Use scalar typehints and return types for new APIs and final classes in libraries
- Fixed in Code Base
- 24 Dec 2017
- Medium
- Build: 4.0-dev
- # 19148
- Diff
- mbabker:php7-tweaks
User tests: Successful: Unsuccessful:
Summary of Changes
Makes use of PHP 7 typing features in classes/methods new to the 4.0 or classes/methods which are declared final and therefore B/C breaks are acceptable for these changes since final classes/methods cannot be extended.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
mbabker
- comment
- 24 Dec 2017
Well, I'm just going by @since tags right now. Since they have 4.0 versions, I can only assume that's the first version they're in place unless they're corrected.
wilsonge
- comment
- 24 Dec 2017
Yeah that's my fault. We haven't tagged any alpha's in 3.9 yet so it still has an __DEPLOY_VERSION__ version. When I tagged the 4.0 alpha it got replaced. That's just my bad :/
| Labels |
Added:
?
|
||
mbabker
- comment
- 24 Dec 2017
Undid changes to MVC factory stuff.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-24 21:37:23 |
| Closed_By | ⇒ | wilsonge |
Unsure about the MVCFactory changes. Currently these are going into the 3.9 branch https://github.com/joomla/joomla-cms/blob/3.9-dev/libraries/src/MVC/Factory/MVCFactoryInterface.php - the 3.9 interface and 4.x interface should be compatible so if we do this we should backport the typehints into 3.9 and document a PHP 7 minimum there i guess as a 4.x compatibility feature