Feeling Lucky
?
?
[#19138] - Enhanced stub generator
- Fixed in Code Base
- 23 Dec 2017
- Medium
- Build: staging
- # 19138
- Diff
- mbabker:generator-update
User tests: Successful: Unsuccessful:
Summary of Changes
Enhances the classmap stub generator by:
- Reading the aliases out of
JLoader::getDeprecatedAliases()which makes deprecation versions available - If a deprecation version is available, a stub doc block stub is written with a
@deprecatedtag (improves IDE integration by flagging the class as deprecated - Adds the "final" keyword to class declarations for final classes (another IDE integration improvement, IDEs will warn if you extend a final class and right now the generator doesn't account for this keyword which could make someone think the alias is extensible when it shouldn't be)
Testing Instructions
Apply the patch, run php build/stubGenerator.php and review the generated stubs.php file. In combination with #19050 you should see entries similar to this now:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Labels |
Added:
?
|
||
laoneo
- comment
- 22 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19138.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 22 Dec 2017
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-23 15:55:43 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Kubik-Rubik
- comment
- 5 Jan 2018
As a workaround, I load the classmap file and extract the correct class names via a small regex:
$class_map = file_get_contents(JPATH_ROOT.'/libraries/classmap.php');
preg_match_all('@\(\'(.*)\',@U', $class_map, $classes_old);
and then set the correct name before assigning it to the file variable:
foreach($classes_old[1] as $class_old)
{
if($oldName == strtolower($class_old))
{
$oldName = $class_old;
break;
}
}
Result:
Kubik-Rubik
- comment
- 5 Jan 2018
Ah, I've just seen your solution. Thank you, Michael!
I have tested this item✅ successfully on 8328f90
Was waiting for this, thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19138.