[#19131] - Category Modal - add notes
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- Easy Test
- # 19131
- Diff
- brianteeman:category_modal
User tests: Successful: Unsuccessful:
If you add a note to a category then it is displayed in the category list but not displayed in the category modal (eg when you select a category for a blog menu item)
This PR adds the note, alias, and full path (on hover) to the modal to make it consistent with the list view
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
| Easy | No | ⇒ | Yes |
Note the space that is underlined.
Was it there before? I can't see what in my changes would cause that
No, however, with the changes expose a space before </a> when</a> is on its own line.
I have fixed it. I think its ugly though and harder to read the code
Yes. My concern that it will be moved back if coding style/formatting is applied with a different PR.
In general it's honestly bad practice to put unwanted whitespace (including line breaks) inside <a> tags. Sooner or later you run into these goofy things where there are extra spaces inside the link.
Nothing wrong with readable and well structured HTML (for the human eye), but the internal contents of <a> tags are one of those places you don't want to be enforcing arbitrary formatting rules.
ok well just merge it then ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19131.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19131.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 16:02:02 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
thanks
I have tested this item✅ successfully on 095561d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19131.