?
avatar Quy
Quy
22 Dec 2017

Steps to reproduce the issue

Just upgraded to PHP 7.2.0

Go to the front end.
Log in.
See php error log.

Actual result

PHP Warning: session_set_save_handler(): Cannot change save handler when session is active in \libraries\joomla\session\storage.php on line 106

PHP Warning: session_set_cookie_params(): Cannot change session cookie parameters when session is active in \libraries\src\Session\Session.php on line 807

System information (as much as possible)

PHP 7.2.0

avatar Quy Quy - open - 22 Dec 2017
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Dec 2017
avatar joomdonation
joomdonation - comment - 22 Dec 2017

I can confirm the issue. Updated our website to PHP 7.2 last week and saw the same warning in error logs

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Dec 2017
Category Front End
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Dec 2017
Status New Confirmed
avatar brianteeman
brianteeman - comment - 22 Dec 2017

Is this PR a fix? #15742

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Dec 2017
Status Confirmed Information Required
avatar Quy
Quy - comment - 22 Dec 2017

Sadly no.

avatar joomdonation
joomdonation - comment - 23 Dec 2017

Just want to add that this issue happens when user logs in and seems like a bug in fork method of Session class https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L792

I don't understand deep enough about session, however, look like https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L804 doesn't need to be called as the session is active (comment it will solve the first warning)

Also, I am not sure this command https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L811 is needed as because after the previous line called $this->_handler->regenerate(true, null);, session is started already

@mbabker Could you please take a look at this issue?

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Dec 2017
Status Information Required Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Dec 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-12-28 15:34:56
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 28 Dec 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 28 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Dec 2017

closed as having Pull Request #19199

avatar haggar30
haggar30 - comment - 14 Jan 2018

Have same issue, solved copy this into php.ini

error_log=C:\Windows\temp\PHP7_errors.log
upload_tmp_dir=C:\Windows\temp
session.save_path=C:\Windows\temp
cgi.force_redirect=0
cgi.fix_pathinfo=1
fastcgi.impersonate=1
fastcgi.logging=0
max_execution_time=300
date.timezone=Europe/Belgrade

avatar Quy
Quy - comment - 14 Jan 2018

@haggar30 can you test PR #19199?

Add a Comment

Login with GitHub to post a comment