Feeling Lucky
?
?
[#19119] - [4.0] Fix Saving and Pinned existing banner fails
- Fixed in Code Base
- 25 Dec 2017
- Medium
- Build: 4.0-dev
- # 19119
- Diff
- Anu1601CS:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #19016
Summary of Changes
Changes in
joomla-cms/administrator/components/com_banners/Table/BannerTable.php
getinstance function should contain a table class name .
So,
Banner --> BannerTable
Testing Instructions
Try to save or pinned banner.
Expected result
Banner saves and pinned.
Actual result
Error occured.
Call to a member function load() on boolean
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
RonakParmar
- comment
- 21 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19119.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 21 Dec 2017
Ready to Commit after two successful tests.
wilsonge
- comment
- 25 Dec 2017
Nice catch! Thanks :)
Congrats on your first contribution!! Welcome to our team :)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-25 01:16:45 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on b72e789
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19119.