In the edit article modal, <a> is used instead of <button>. Maybe use <a> to be consistent.

What I learned is that using the < a> in a form is wrong. Although it works, it behaves differently in e.g. accessibility use cases (for a Screen-Reader a link behaves different to a button (tab index, space bar / enter behavior)).
https://css-tricks.com/use-button-element/

Op 23 dec. 2017 19:11, om 19:11, Quy notifications@github.com schreef:

In the edit article modal, <a> is used instead of <button>. Maybe
use <a> to be consistent.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#19116 (comment)

I have tested this item ✅ successfully on 71bb5d9

I have tested this item ✅ successfully on 71bb5d9

What I learned is that using the < a> in a form is wrong

The reason for A tag instead of BUTTON, which is the correct one, has to do with the stupid bootstrap modal script! To verify this go to the page with this modal and press enter (it doesn't matter which element has focus), the form will be submitted although it shouldn't. Now change the Button to A tags and retest, form will not submit!

This is a hack that is needed atm as we cannot change the Bootstrap 2.3.2 javascript!

Ready to Commit after two successful tests.

@franz-wohlkoenig NO, the tags need to be converted to A for the reason I stated above. Please remove the RTC label

Hello @dgt41, just tried what you described: open the modal, press enter key.
The form stays open and doesn't close...
I think this is because on the form there is now NO button of type submit (all buttons are of type = 'button').
So I tested this successfully

You need to test this with Firefox

I am testing this with Firefox (Quantum): 57.0.3 (64-bit)
cannot reproduce the case you are describing: sorry :(

I have tested this item ? unsuccessfully on 71bb5d9

This time a tested in Google Chrome 63.0.3239.108

Because here is it not a real issue, because I can not reproduce it !!!

See earlier test too.

I can not reproduce the case of @dgt41 in Firefox and Google Chrome.

@Ruud68 have you tested in Google Chrome (without the patch tester)? Result?
So not, can you test?

Hi @sandewt I have just installed Google Chrome (Version 63.0.3239.108 (Official Build) (64-bit))
my patch works, and also the issue reported by @dgt41 regarding the closing of the modal when pressing the [enter] key: pressing the [enter] key does NOT close the modal (tested now on both Firefox and Chrome)

You tested unsuccessful, what is it that you tested? I am confused :)

Hi @Ruud68,

There is a misunderstanding.

I mean with unsuccessfull in Google Chrome that the plugin is (remains) checked in without and with the patch tester. So you don't need the patch tester!

I can't reproduce the case of @dgt41 in Firefox and Google Chrome.

Gr.

Okay, retested everything both with FF and Chrome.

without patch:
Firefox has the issue that the plugin is not checked in when closing the modal window via the [close] button
Chrome does NOT have this issue: the modal is checked in correct (as found by @sandewt )
The issue reported by @dgt41 that pressing the enter key in the modal window closes the modal is NOT reproducible on both FF and Chrome.

with the patch applied:
Firefox checks in the modal CORRECT when closing the modal with the [close] button
Chrome checks in the modal CORRECT when closing the modal with the [close] button
Again: The issue reported by @dgt41 that pressing the enter key in the modal window closes the modal is NOT reproducible on both FF and Chrome.

So the issue raised by @dgt41 that blocks this patch from becoming RTC CANNOT be reproduced (at least by me and @sandewt ). I have tried to reproduce on both a clean install as on (multiple) production sites).

How to proceed?

@Ruud68 I raised the issue because I had to patch this couple of times in the past, if this is not an issue anymore then this is RTC!
Just to be clear here I was talking about #14483
@franz-wohlkoenig you can move this to RTC again

Ready to Commit as stated above.