Feeling Lucky
?
[#19081] - [CS] Code Style fixes for administrator/components/com_templates/
- Fixed in Code Base
- 20 Dec 2017
- Medium
- Build: staging
- # 19081
- Diff
- photodude:PHPCS2-com_templates
- Pending hound Hound is busy reviewing changes... Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Expected 1 newline after opening brace
- Blank line found at start of control structure
- Line indented incorrectly
- Whitespace found at end of line
- Expected intention before asterisk
- Closing parenthesis of a multi-line function call must be on a line by itself
- Please consider an empty line before the return statement;
- No blank line found after control structure
- Tabs must be used to indent lines; spaces are not allowed
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
?
|
||
photodude
- comment
- 16 Dec 2017
Note: Drone failing is just Drone having problems.
here is the unrelated drone error
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: The remote end hung up unexpectedly
Quy
- comment
- 16 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19081.
Quy
- comment
- 18 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19081.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-20 00:11:58 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on ede03da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19081.