? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
15 Dec 2017

Summary of Changes

In searching archived articles, catid is expected to an array, however, it can be changed in the URL to be non-array which results in warnings. This PR ensures that catid be an (integer) array.

Testing Instructions

Install Test English (GB) Sample Data demo.
Set Search Engine Friendly URLs to No.
On the front end, click Archived Articles.
In the browser's address bar, append &catid=0 to the URL.
See warnings above the filter form.

Expected result

No warnings.

Actual result

Warning: array_diff(): Argument #1 is not an array in C:\xampp\htdocs\joomla-cms-staging\components\com_content\models\archive.php on line 90

Warning: array_values() expects parameter 1 to be array, null given in C:\xampp\htdocs\joomla-cms-staging\components\com_content\models\archive.php on line 90

Documentation Changes Required

None

avatar Quy Quy - open - 15 Dec 2017
avatar Quy Quy - change - 15 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2017
Category Front End com_content
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Dec 2017

I have tested this item successfully on 0ccf28b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19075.

avatar Quy
Quy - comment - 15 Dec 2017

Related to #15184. @alikon Can you test please?

avatar Joomill Joomill - test_item - 16 Dec 2017 - Tested successfully
avatar Joomill
Joomill - comment - 16 Dec 2017

I have tested this item successfully on 0ccf28b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19075.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Dec 2017
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 16 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 18 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-18 03:30:48
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 18 Dec 2017
avatar mbabker mbabker - merge - 18 Dec 2017

Add a Comment

Login with GitHub to post a comment