[#19072] - Fix filepath to PHPMailer language file
- Fixed in Code Base
- 18 Dec 2017
- Medium
- Build: staging
- # 19072
- Diff
- mbabker:fix-mailer-language-path
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #19071
Summary of Changes
From what I can tell, after PHPMailer/PHPMailer@6a6165f introduced in PHPMailer 5.2.17 our language file loading has been broken for the library. This fixes it.
Testing Instructions
Whatever it takes to get language strings out of PHPMailer should now be translated with Joomla's strings versus the hardcoded English that'll be loading now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
No idea to be honest. I didn't even actually test mail sending, I went straight for the "language file not loading correctly" thing since that can be debugged/fixed without sending mail and traced through that until I had a correct file name/path.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.
@Anu1601CS thanks for Test. As this is a Pull Request (PR) which is set "Ready to Commit" (RTC) its not necessary to test again.
Maybe you can list on Issue Tracker PR having one Test and need a second one (click st "Search Tools" then "Tests" > "Needs one")?
ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.
What is the impact of this for non-en-GB languages?
The untranslated strings from phpmailer will be correctly translated by joomla
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-18 03:31:30 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I tested this in j4 against the issue i reported in 19071. the problem is that it solves the issue of the message appearing incorrectly that I reported then but now I cant create an error to test that the message is now correct. So I am guessing the previous error message was completely incorrect and that by fixing the bug here it has resolved that