[#19047] - Fix priority order language for tags in forms
- Closed
- 24 Mar 2022
- Medium
- Build: staging
- # 19047
- Diff
- inode64:staging
- Success hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
When we create or manage tags from frontend we have to check the param 'tag_list_language_filter' to show only corresponding tags.
Summary of Changes
In the backend, we check only the language in the form because the manager can create content in any language.
In frontend, first of all, we use the language from the form and later we evaluate the param 'tag_list_language_filter' to select the correct language.
Testing Instructions
I have checked that in the backend it works as good as it does now.
Expected result
It shows only tags based on the param 'tag_list_language_filter' or the form in the frontend
Actual result
It shows tags of all languages
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | com_tags Libraries |
From the backend, It shows all tags, minus when in the form field is enabled language.
You change the option "Language Filter" from the backend in options Tags -> Item Selection
When selected to 'All' show all tags. and if selected to 'current' only it shows the tags in the current language selected in the frontend, and You selected a language, it only shows this language
This should be tested on a multilingual site
I opened the related issue #17244 on backend and I am not convinced that in backend all tags must be shown: the admin user can freely select the language but then only selected language tags should be shown for consistency, otherwise the user can select one language and a tag of another language, the backend should prevent it.
| Labels |
Added:
?
Removed: ? |
||
| Category | Libraries com_tags | ⇒ | Libraries |
Sorry that it took so long to respond here. As this fix changes a behavior where Joomla users are used to it, it should be ported to version 4. Can you rebase your branch to 4.2 so we can reevaluate it for testing. In the meantime I'm closing this pr. When ready, please reopen again. Thanks for your contribution making Joomla better.
Sorry that it took so long to respond here. As this fix changes a behavior where Joomla users are used to it, it should be ported to version 4. Can you rebase your branch to 4.2 so we can reevaluate it for testing. In the meantime I'm closing this pr. When ready, please reopen again. Thanks for your contribution making Joomla better.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 08:20:26 |
| Closed_By | ⇒ | laoneo |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 08:20:26 |
| Closed_By | ⇒ | laoneo |
@inode64 can you please give Instructions how to test?