Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19044] - [4.0] Fix missing filters (com_menus & com_associations)

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
12 Dec 2017

Pull Request for Issue #18815

Summary of Changes

Fix the filters

Testing Instructions

  • Go to administrator/index.php?option=com_menus&view=menus
  • You should see a filter to switch between Site and Administrator
  • Go to administrator/index.php?option=com_menus&view=items
  • You should see a filter to switch between Site and Administrator
  • You should see a filter to select the menu type
  • Go to administrator/index.php?option=com_associations
  • You should see a filter to for Item type and Language
avatar C-Lodder C-Lodder - open - 12 Dec 2017
avatar C-Lodder C-Lodder - change - 12 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2017
Category ⇒ Administration com_associations com_menus
avatar C-Lodder C-Lodder - change - 12 Dec 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 12 Dec 2017
avatar infograf768
infograf768 - comment - 13 Dec 2017

This works great. Can you please also change the lang constant which has nothing to do here:
<joomla-alert type="warning"><?php echo JText::_('COM_LANGUAGES_MULTILANGSTATUS_NONE'); ?></joomla-alert>
to
<joomla-alert type="warning"><?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?></joomla-alert>
in com_menus/tmpl/items/default.php and in com_menus/tmpl/items/modal

EDIT: no use. Will correct with new PR including some other stuff

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 13 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Dec 2017

I have tested this item ✅ successfully on c1edfed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.

avatar infograf768
infograf768 - comment - 13 Dec 2017

@C-Lodder
I will correct the code to use the new attribute, and at the same time take off that wrong constant.
Therefore, let's merge this as I will have to modify the same file.

avatar infograf768 infograf768 - test_item - 13 Dec 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 13 Dec 2017

I have tested this item ✅ successfully on c1edfed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.

avatar infograf768 infograf768 - change - 13 Dec 2017
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 13 Dec 2017

rtc

@wilsonge Please merge asap to let me make new PR

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19044.

avatar wilsonge wilsonge - change - 13 Dec 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-12-13 20:09:09
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 Dec 2017
avatar wilsonge wilsonge - merge - 13 Dec 2017
avatar infograf768
infograf768 - comment - 14 Dec 2017

Thanks @wilsonge
@C-Lodder
We are having some discussions about this new noresults attribute in the maintainers chat.
Shall we keep it or not is the question.

avatar C-Lodder
C-Lodder - comment - 14 Dec 2017

I don't mind whether it's kept or not. I'm just a UI dev

avatar infograf768
infograf768 - comment - 14 Dec 2017

You can see what we can get if we keep the attribute in 4.0
For com_associations, com_content (articles and Featured), com_categories, com_associations.
noresults.diff.zip

For com_associations, one has also to delete in its custom searchtools layout the bar.php

Add a Comment

Login with GitHub to post a comment