[#19038] - [4.1] com_media modifications for front-end use
- Closed
- 19 Oct 2021
- Medium
- Build: 4.0-dev
- # 19038
- Diff
- stutteringp0et:patch-9
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
This small change allows media fields to be used in user profiles, where a user is not authorized for core.create in com_users - they can be authorized in com_media. In conjunction with a filesystem plugin, a user can be granted access to com_media a limited area of the filesystem. This change should not impact anything other than front-end media modals.
Summary of Changes
allow core.create for com_media to open com_media
Testing Instructions
Create a user custom field of type media as a regular user (registered group). Editing your profile, the media field will have no button to open the media manager because the user has no access.
Apply this change, and allow "Regisered" user group "create" permissions. The user is now given the "Select"
Expected result
media custom fields usable
Actual result
after change, users can use media fields
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_media Plugins |
| Labels |
Added:
?
|
||
dgt41
- | Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
This is so far out of date, should I just close it and open a new PR?
@stutteringp0et Its enough to resolve conflicting files so the Pull Request can be tested as @sanderpotjer comment above.
Please resolve conflicting files so this PR can get tested at Worldwide Pizza, Bugs & Fun, October 19th
Yeah, the conflicting file no longer exists. It's been replaced by components/com_media/src/Dispatcher.php
I think I must close and submit a new PR, unless someone can tell me how to do that.
@stutteringp0et Since there are minor changes, the easiest would be to close and submit a new PR.
Was a new PR ever created for this?
I have not tested this item.
Looks like the code base has changed too much since this was made
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19038.
I have tested this item
Looks like the code base has changed too much since this was made
The file marked for modification does not exist: components/com_media/dispatcher.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19038.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19038.
Got the following error after applying patch.
"The file marked for modification does not exist: components/com_media/dispatcher.php"
I have tested this item
Warning "The file marked for modification does not exist: components/com_media/dispatcher.php" displayed on applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19038.
@stutteringp0et please fix or close this pr.
@stutteringp0et here's the steps I think you need to perform to remove the conflict and apply your change to the new location of the dispatcher.php. (I'll leave better coders to indicate if I'm wrong here)
- Add your modification to around line 56 in the new components/com_media/src/Dispatcher/Dispatcher.php
- Remove components/com_media/dispatcher.php from your previous commit
- Commit the new changes, and it should be ready to go.
Otherwise, close the PR and start again.
BTW I like the premise here - Not sure if it resolves an issue I'm yet to raise with accessing media in the editor, but gives me somewhere to look when I get back to it.
Reviewing this as part of a "Outstanding PR Status List" exercise to work on reducing the number of outstanding PR that have been otherwise orphaned, neglected or forgotten instead of being merged. See Glip Bugs & Fun @ Home channel for more information.
I am moving this to 4.1, we are in beta and this is a new feature.
| Title |
|
||||||
Closing due to reasons commented above. Feel free to re-open if this is wrong.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-19 13:00:29 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: ? |
||
@stutteringp0et thanks for the PR! Can you please fix the merge conflict so this can properly be tested?