[#19034] - [4.0] Multilingual: Only display the articles field 'show_associations' when associations are set.
- Fixed in Code Base
- 11 Dec 2017
- Medium
- Build: 4.0-dev
- # 19034
- Diff
- infograf768:show_assoc_40
User tests: Successful: Unsuccessful:
Summary of Changes
Added new field type AssocField to display the field only when Associations::isEnabled() is enabled.
Testing Instructions
Test creating a new article menu item, featured menu item, category list or blog menu item.
Test editing or creating an article.
In all cases look at the Options Tab.
Before patch
Before patch, the field show_associations displays whatever the Associations settings in the languagefilter system plugin, and whether the plugin is enabled or not.
After patch
The field will not display when Associations are set to NO or the languagefilter is disabled.
Note
- We can also create a new fieldtype to prevent showing the field in Articles Configuration as we would need there an override for the radio field type.
- This PR also solves the issue when changing a site from multilingual to monolanguage and associations had been created. Before PR, if associations had been set and show associations implemented, the flag/lang_code would still show in the info-block of the articles concerned.
After patch no more.
See discussion here
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End |
| Labels |
Added:
?
|
||
@infograf768 could you fix the CS issues:
FILE: ...la/joomla-cms/administrator/components/com_content/Field/AssocField.php
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
6 | ERROR | @copyright tag comment indented incorrectly; expected 3 spaces but found 2
7 | ERROR | @license tag comment indented incorrectly; expected 5 spaces but found 4
@rdeutz cs corrected.
@franz-wohlkoenig It can be tested for all cases.
Test creating a new article menu item, featured menu item, category list or blog menu item. Test editing or creating an article.
The tests only concern the display or not of the field under the conditions described.
I have tested this item
@infograf768 In the different Menus showing or hiding of Field works.
Test editing or creating an article.
This don't work as "The requested page can't be found." is shown if Plugins "Language Code" and "Language Filter" ar enabled.
If
The tests only concern the display or not of the field under the conditions described.
is correct i can mark Test as successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19034.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19034.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-11 22:10:08 |
| Closed_By | ⇒ | wilsonge |
Thanks JM :)
@infograf768 can this PR be tested? Should it be tested on article menu item, featured menu item, category list or blog menu item or is one of them enough?