Feeling Lucky
?
[#19029] - iframe accessibility
- Fixed in Code Base
- 10 Dec 2017
- Medium
- Build: staging
- # 19029
- Diff
- brianteeman:wrapper
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
every iframe should have a title attribute
This pr ensures that the com_wrapper and mod_wrapper have a title in the iframe link
for the module it simply uses the module title
for the component it uses the menu name or if set the page heading
Testing Instructions
Create a menu item of type wrapper and a module of type wrapper
Check the generated source code for the iframe link and you will see no title attribute
Apply the PR and check the source again and the title attribute is set
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_wrapper Modules |
Joomill
- comment
- 10 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19029.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 10 Dec 2017
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-10 14:28:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 10 Dec 2017
Thanks!
brianteeman
- comment
- 10 Dec 2017
Thanks
I have tested this item✅ successfully on f504f66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19029.