? Pending

User tests: Successful: Unsuccessful:

avatar stutteringp0et
stutteringp0et
8 Dec 2017

unescaped classes causing issues saving default values in fields - maybe other stuff too.

Pull Request for Issue #19018 .

Summary of Changes

Escaped some classnames

Testing Instructions

  1. Create a new field (I tried text, calendar, and one of my own field extensions)
  2. type a default value
  3. hit save
  4. scratch your head (optional)

Expected result

default saved

Actual result

An error has occurred.
0 Class 'Joomla\Component\Fields\Administrator\Plugin\DOMElement' not found

Documentation Changes Required

none

avatar stutteringp0et stutteringp0et - open - 8 Dec 2017
avatar stutteringp0et stutteringp0et - change - 8 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2017
Category Administration com_fields
avatar joomla-cms-bot joomla-cms-bot - edited - 8 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Dec 2017
Title
escaped some classes
[4.0] escaped some classes
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 8 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

I have tested this item successfully on 817f5f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19019.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Dec 2017
Easy No Yes
avatar laoneo laoneo - test_item - 8 Dec 2017 - Tested successfully
avatar laoneo
laoneo - comment - 8 Dec 2017

I have tested this item successfully on 817f5f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19019.

avatar stutteringp0et
stutteringp0et - comment - 8 Dec 2017

Travis-CI seems to be functioning again - do I need to do something to trigger a re-test?

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Dec 2017

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 10 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-10 14:28:47
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Dec 2017
avatar wilsonge wilsonge - merge - 10 Dec 2017
avatar wilsonge
wilsonge - comment - 10 Dec 2017

It's ok. Travis has issues in the 4.0 branch at the moment. I'm working on it :)

Add a Comment

Login with GitHub to post a comment