? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
6 Dec 2017

Pull Request for Issue #18992.

Summary of Changes

Prepares an item in the tags view with the custom fields. It mapps the tag context to the propper one of the item which has the tag.

Testing Instructions

  • Create an article custom field.
  • Create an article with a value of the custom field and give it a tag.
  • Create a menu item "Tagged Items" and select the tag you gave the article, also set "Item Description" to Show as on the screenshot below
    image
  • Open the menu on the front

Expected result

The custom fields are shown on the item.

Actual result

No custom fields are shown.

avatar laoneo laoneo - open - 6 Dec 2017
avatar laoneo laoneo - change - 6 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2017
Category Front End Plugins
avatar laoneo laoneo - change - 6 Dec 2017
The description was changed
avatar laoneo laoneo - edited - 6 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

@shionphan can you please test?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Dec 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

I have tested this item ๐Ÿ”ด unsuccessfully on 6056d1d

Field (Type: Text, using Default Settings) isn't shown applied PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.

avatar laoneo
laoneo - comment - 7 Dec 2017

@franz-wohlkoenig what shows up on the front? Did you not set a value ion the article for the custom field?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

In Frontend nothing new (=Field-Value) is shown. Value in Field is set.

avatar laoneo
laoneo - comment - 7 Dec 2017

Can you post a screenshot of your page? Are you sure you took the right menu item type?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

You see a little more Space between Title and Text using PR.

Without PR

without

With PR

with

avatar laoneo
laoneo - comment - 7 Dec 2017

What's in the space, when you inspect it with the developer tools of your browser?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

bildschirmfoto 2017-12-07 um 11 30 08

avatar laoneo
laoneo - comment - 7 Dec 2017

So a field is loaded which means it works. It can be an override or another patch installed which interferes on your site. Lets see if others have the same behavior.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

If other have not same Behaviour i install new one.

avatar esedic
esedic - comment - 7 Dec 2017

I also can't get custom fields to display.

<dl class="fields-container"></dl>

is created but it's empty.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

Same Behaviour on clean Install.

avatar shionphan
shionphan - comment - 8 Dec 2017

@franz-wohlkoenig @laoneo

I have test code <?php echo $item->event->beforeDisplayContent; ?> successfull.
It seems great. Thanks all.

Screenshot was script console.log

image

Issue

Some fields can not display.

Others fields what be set default value could be displaed.

Possible Causes

Find code $fields = FieldsHelper::getFields($context, $item, true); in /plugins/system/fields/fields.php

Add console code

$console = json_encode($fields);
echo ('<script>console.log(' . $console . ')</script>');

Some field value In article page will be displayed, But it dose not display in com_tags page.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

@shionphan please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar laoneo
laoneo - comment - 8 Dec 2017

Just tested it and the custom fields values are shown as expected.
image

Can you guys exactly describe what for steps you did where the field is not displayed. It would be helpfull if you can test with the latest staging code and from a fresh joomla installation.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

System information

3.8.3-rc
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • PHP 7.0.22
  • MySQLi 5.6.35

Create new Field

bildschirmfoto 2017-12-08 um 09 26 15

Article: Value on Field and Tag

bildschirmfoto 2017-12-08 um 09 29 23

Menu "Tags ยป Tagged Items" using Tag and Item Description to show

bildschirmfoto 2017-12-08 um 09 31 33

Result:

bildschirmfoto 2017-12-08 um 09 34 23

avatar laoneo
laoneo - comment - 8 Dec 2017

Are you testing it with the latest staging?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

I test on 3.8.3-rc, former Test nightly Builds.

avatar shionphan
shionphan - comment - 9 Dec 2017

Tested successfull that if I install a new Joomla clean package, but it dose not work on my site.
I will rebuild database for continue to follow up.

avatar laoneo
laoneo - comment - 10 Dec 2017

@shionphan please fill the test instructions from Franz to mark the pr as a successful test. Thanks.

avatar shionphan shionphan - test_item - 14 Dec 2017 - Tested successfully
avatar shionphan
shionphan - comment - 14 Dec 2017

I have tested this item โœ… successfully on 6056d1d

Tested successfull that if I install a new Joomla clean package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.

avatar shionphan
shionphan - comment - 14 Dec 2017

@laoneo Sorry for the work too busy.
A new problem you have to know. Tags page will display items fields when i add new items. However, the old item data will not be displayed.

We know that fields data is different from items data in mysql (table name is ##_contentitem_tag_map.content_item_id). I can guarantee that I add the data operation is the same.

Solution

Line 423 (Your post)

$item->id       = $item->content_id;

Change into:

$item->id       = $item->content_item_id;

Demo pages

https://www.infinisign.com/products/all-type/multi-domain (Chinese Language)

avatar laoneo laoneo - change - 14 Dec 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 14 Dec 2017

@shionphan thanks for the hint, changed it. Can you guys please retest if it is working now as expected?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Dec 2017

I have tested this item โœ… successfully on f440255

bildschirmfoto 2017-12-14 um 09 12 11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.
avatar shionphan shionphan - test_item - 14 Dec 2017 - Tested successfully
avatar shionphan
shionphan - comment - 14 Dec 2017

I have tested this item โœ… successfully on f440255

Perfect

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19006.

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 18 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-18 03:33:32
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Dec 2017
avatar mbabker mbabker - merge - 18 Dec 2017

Add a Comment

Login with GitHub to post a comment