Feeling Lucky
?
[#19003] - Undefined variable $app and $data fixed. Fixes #12768
- Fixed in Code Base
- 11 Dec 2017
- Medium
- Build: staging
- # 19003
- Diff
- izharaazmi:undefined-vars
- Pending continuous-integration/drone/pr this build is pending Details
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12768
Summary of Changes
Added the missing definition for $data and replace$app with $this->app
Testing Instructions
Please do a code review, should be enough. I am fixing this just to avoid the other issue closed. Will add instructions later if really needed.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
franz-wohlkoenig
- comment
- 8 Dec 2017
reading "Code Review" thinking @Quy. Can you please?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19003.
csthomas
- comment
- 8 Dec 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19003.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 8 Dec 2017
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-11 14:30:46 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on a0c2dbe
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19003.