[#19001] - [4.0] Fix Issue Session timer not working.
- Closed
- 6 Dec 2017
- Medium
- Build: 4.0-dev
- # 19001
- Diff
- Anu1601CS:4.0-dev
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18921
Summary of Changes
Changes in :
\joomla-cms\libraries\vendor\joomla\session\src\Session.php
In Start a session and Restart an expired or locked session.
Added : Validate session if the session isn't valid and if it expired then try to restart else destroy it.
Testing Instructions
Apply patch and do nothing for period of time you set in session timer (lifetime).
Expected result
auto logout.
Actual result
still active.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries Composer Change |
| Title |
|
||||||
| Title |
|
||||||
Understand completely. But, the file you've changed is technically a third party dependency to this repository (as all files in libraries/vendor are). So the change needs to be applied to the source repository otherwise the next time a composer update is run on this repository the change will be overwritten.
Superseded by joomla-framework/session#34
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-06 17:59:38 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
No, issue should stay open here until the PR is merged upstream and then the fix applied to this repo as well.
This PR needs to be submitted against https://github.com/joomla-framework/session/tree/2.0-dev
The
libraries/vendordirectory is all files from external repositories as compared to the CMS repo.