Feeling Lucky
[#18999] - [4.0] Remove "version" parameter from recaptcha plugin
- Closed
- 2 Feb 2018
- Medium
- Build: 4.0-dev
- # 18999
- Diff
- C-Lodder:recap
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The recaptcha plugin only uses version 2, therefore I don't see the need to have a parameter for this at all.
This PR simply removes that parameter
@mbabker thoughts?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
mbabker
- comment
- 6 Dec 2017
I left it since IIRC the PR with the NoCaptcha support was adding it to the same plugin so it's less merge conflicts to deal with. If it goes into a separate plugin then go ahead and remove it.
Not saying either approach is preferred right now, just why I left the param in place.
C-Lodder
- comment
- 6 Dec 2017
Cool, I'll leave this open whilst that decision gets made
franz-wohlkoenig
- | Status | Pending | ⇒ | Needs Review |
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-02 10:46:12 |
| Closed_By | ⇒ | C-Lodder |
My thought is to add the noCaptcha to this plugin. See this open PR #16599