Feeling Lucky
?
[#18996] - [4.0] Fix issue #18973 tinymce Illegal string offset error
- Fixed in Code Base
- 11 Dec 2017
- Medium
- Build: 4.0-dev
- # 18996
- Diff
- joomdonation:patch-3
- Pending continuous-integration/drone/pr this build is pending Details
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This small PR fixes the issue #18973. The code at the below lines https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/editors/tinymce/tinymce.php#L755-L756 expects $options is an array but string is passed PlgButtonFields plugin and it causes the error
I just modified code to pass an array (like other editor-xtd plugins) to get the issue sorted
Testing Instructions
- Confirm the issue described at #18973
- Apply patch, confirm the warning messages gone
- Click on Field button in TinyMCE plugin, make sure the popup opens and you can select the field
You might need to enable the plugin Button - Field if it is not enabled on your Joomla 4 installation
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
franz-wohlkoenig
- comment
- 7 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18996.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 7 Dec 2017
Ready to Commit after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-11 02:20:50 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on da4dca5
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18996.