J4 Issue ?
avatar brianteeman
brianteeman
5 Dec 2017

Enable the option in global config to enable editing modules AND menus in the front end on hover

Modules works but menus doesnt as no icon is shown

avatar brianteeman brianteeman - open - 5 Dec 2017
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Dec 2017
avatar C-Lodder
C-Lodder - comment - 6 Dec 2017

Note to self - finish this: #18786

avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Dec 2017
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Dec 2017
Category com_menus Front End
avatar C-Lodder
C-Lodder - comment - 11 Dec 2017

@brianteeman - I've just finished rewriting this script and it's ready to commit. Whilst I'm at it, in the Global Config, there are currently 3 options for Mouse-over Edit Icons for

  1. Modules & Menus
  2. Modules
  3. None

I was thinking to change this to:

Front-end module editing (switcher)

  • Off
  • On

Simply because the menu IS a module and I can't see any reason to have modules but not menus. Would be nice to just simplify this too.

thoughts?

avatar brianteeman
brianteeman - comment - 11 Dec 2017

the menus option is very different to the modules option

avatar C-Lodder
C-Lodder - comment - 11 Dec 2017

Is there anywhere where I can get more info on that?

avatar brianteeman
brianteeman - comment - 11 Dec 2017

You can try it in J3 ;)
or watch this video https://developer.joomla.org/cms/user-experience/610-jux-code-sprint-report.html

(note that was when there was only backend module editing - front end editing came later)

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Dec 2017
Build staging 4.0-dev
avatar brianteeman
brianteeman - comment - 5 Jan 2018

The reason why it doesnt work is in the frontediting.js
It is trying to

// Get menu ItemId from the item-nnn class of the li element of the menu:

but it cant as in j4 the li element doesnt have that class
in fact it doesnt have a unique class which might be a problem if someone wants to target a link for additional styling etc which was no problem at all in j3

avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman brianteeman - change - 3 Apr 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-04-03 18:51:42
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Apr 2018

Add a Comment

Login with GitHub to post a comment