? Pending

User tests: Successful: Unsuccessful:

avatar Septdir
Septdir
5 Dec 2017

Summary of Changes

Commit returns the old function of using the current date as alias in system menu items if alias is empty.

Testing Instructions

  • Install Joomla 3.8.2
  • Apply this path
  • Create any system menu items (url, heading, alias,'separator)
    Leave the alias field empty.

Expected result

Alias of this menu item will look like this 2017-12-05-15-29-29

avatar Septdir Septdir - open - 5 Dec 2017
avatar Septdir Septdir - change - 5 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2017
Category Libraries
avatar Septdir Septdir - change - 5 Dec 2017
The description was changed
avatar Septdir Septdir - edited - 5 Dec 2017
avatar Septdir Septdir - change - 5 Dec 2017
Title
[3.8] using the current date as alias in system menu items if alias is empty.
[3.8] Using the current date as alias in system menu items if alias is empty.
avatar Septdir Septdir - edited - 5 Dec 2017
avatar Quy
Quy - comment - 5 Dec 2017

The alias placeholder text Auto-generate from title is now misleading.

avatar Septdir
Septdir - comment - 5 Dec 2017

@Quy I don't remember which text was there before this function was removed.
But as far as I can remember, placeholder was same.

avatar brianteeman
brianteeman - comment - 5 Dec 2017

This change was intentional why are you reverting it

avatar Septdir
Septdir - comment - 5 Dec 2017

@brianteeman
The reason is simple. Convenience. In my projects, I very often use system menu items. And it is not uncommon that their alias coincides with existing or created ones, so as to avoid problems they have to write each time with their hands. And a similar problem arises not only for me. And after each update, you have to re-write the hack.
The larger the project the more there are system menu items. And alias these points are not needed.

In addition, I missed the discussion on the topic of deleting this function, well, or just do not remember, but I clearly remember my inconvenience caused by this cancellation.

I do not insist on accepting this PR, but in my opinion and the opinion of my friends, this function is very useful. I can show a screenshot of the site where about 20 menus and about 500 menu items, many of which are system menu items, but I think you'll roar to me on the floor.

avatar brianteeman
brianteeman - comment - 5 Dec 2017

The reason for the change was so that users who have real menus as sub menus of system menus have real data in the menu path and not dates eg

Example.com/system/sports/article.html
Instead of
Example.com/2018-01-17/sports/article.html

avatar Septdir
Septdir - comment - 5 Dec 2017

@brianteeman In such cases, you can fill in the alias field, this is much more logical than when you need to fill out the ailas field for the menu item delimiter. Which in action performs the function of a visual separator. Or for an external link.

I think so there is a page in the url that the visitor should have the opportunity to go to it. And where will I go if I go to this url Example.com/2018-01-17 ?
I'm not an SEO specialist, but it's not true to mine.

Now I know reason =)

avatar pavluk pavluk - test_item - 5 Dec 2017 - Tested successfully
avatar pavluk
pavluk - comment - 5 Dec 2017

I have tested this item successfully on 37cae77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18985.

avatar tonypartridge
tonypartridge - comment - 5 Dec 2017

No, this is very bad.

Users not knowing how the menu structures work end up killing their SEO.

A better solution would be to test the Alias on pre-save then add a unique 5digit number if one already exists.

avatar brianteeman
brianteeman - comment - 5 Dec 2017

For reference #10756

avatar Septdir
Septdir - comment - 5 Dec 2017

The problem occurs when you create a component menu item . Every time one has to remember whether there is a heading item with such alias or not. . And then every time you look for him. then change alias. then again change alias, then again and again, And in a few days the story repeats itself

System menu items should not be present at all in the site structure. They are more of a decorative nature, or refer to third-party resources. But somehow everyone forgot about this.

avatar brianteeman
brianteeman - comment - 5 Dec 2017

Sorry but I completely disagree with your view on the system menu alias

avatar tonypartridge
tonypartridge - comment - 5 Dec 2017

No that's completely wrong @Septdir the site structure is completely defined of the menu item and how it should be done. Even more so now you can create content form the menu item level.

From an SEO Perspective you need to be having unique aliases which following the correct pattern. If you are having multiples of the same name at the same level there something if very wrong with your build in my opinion. I can't see at what point you would need this? Maybe at the level of a footer or hidden mobile menu, but again when you build that you know you are using system aliases you can can type in menuname-alias1 for instance sake.

@dgt41 what are your thoughts on writing a neat little ajax validator pre-save for the menu item alias validation?

avatar Septdir
Septdir - comment - 5 Dec 2017

@brianteeman I understand your position, you brought good arguments. At me the vidin have at you the. You look from the point of view of the beginner to use, I also look from the point of view of administering sites where hundreds of menu items, more than half of which system menu items in particular "Menu Item Alias" and "alias from title" give me discomfort.

@tonypartridge menuname-alias1 for 20-30 menu items. Are you seriously?

what are your thoughts on writing a neat little ajax validator pre-save for the menu item alias validation?

This is a great idea, but does not solve this "problem".

If PR does not accept I will write a system or content plugin without any problems.

avatar brianteeman
brianteeman - comment - 5 Dec 2017

If you have a site with hundreds of menu items then you are really doing it wrong

avatar brianteeman
brianteeman - comment - 5 Dec 2017

sorry for that - its not my right to tell you if you are doing something right or wrong but joomla always has to consider the needs of the many more than the needs of the few

avatar Septdir
Septdir - comment - 5 Dec 2017

If you have a site with hundreds of menu items then you are really doing it wrong

Simply sites are large =) and there are a lot of different sub menus.

sorry for that - its not my right to tell you if you are doing something right or wrong but joomla always has to consider the needs of the many more than the needs of the few

That's all right.
It's just that almost all my friends complain about this, so I decided to try PR.

If the issue is exhausted PR can be closed.

I do not regret having tried it. I did this PR very quickly.
Now I can safely create a plugin. I think it's even better. Maybe I will not even use the current date for alias and I'll think up something more interesting.

PS I really liked the idea with ajax checking alias. It would save a lot of time.

avatar tonypartridge
tonypartridge - comment - 5 Dec 2017

I think your reasoning is right to a point i.e. we validate the data before submitting the form. Then you know you need to change it, its just how we go about doing that as a core solution.

On 5 Dec 2017, 21:52 +0000, Igor Berdichevskiy notifications@github.com, wrote:

If you have a site with hundreds of menu items then you are really doing it wrong
Simply sites are large =) and there are a lot of different under the menu. Though in what you are right to do such sites on joomla not the best invention.
sorry for that - its not my right to tell you if you are doing something right or wrong but joomla always has to consider the needs of the many more than the needs of the few
Nothing wrong.
It's just that almost all my friends complain about this, so I decided to try PR.
If the issue is exhausted PR can be closed.
I do not regret having tried it. I did this PR very quickly.
Now I can safely create a plugin, knowing that I tried. I think it's even better.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Septdir
Septdir - comment - 5 Dec 2017

@tonypartridge

we validate the data before submitting the form.

It's really much more convenient than checking the data after sending.
There is one shortcoming. And what if two administrators at the same time will check the same alias. For example
One checks alias main-menu-seperator-1 and the second administrator checksmain-menu-seperator-1. After the error, both change the number by 2.
The situation is of course absurd, but possible

avatar tonypartridge
tonypartridge - comment - 5 Dec 2017

It is, but we then have the serverside validation we currently have which it would spit an error should it fail.

avatar Septdir
Septdir - comment - 5 Dec 2017

Yes you are right.

avatar joomla-cms-bot joomla-cms-bot - edited - 6 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Dec 2017
Status Pending Information Required
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2017
Title
[3.8] Using the current date as alias in system menu items if alias is empty.
Using the current date as alias in system menu items if alias is empty.
avatar joomla-cms-bot joomla-cms-bot - edited - 6 Dec 2017
avatar infograf768
infograf768 - comment - 6 Dec 2017

@Septdir
If you are satisfied with the replies, please close PR.

avatar Septdir Septdir - change - 6 Dec 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-12-06 07:33:39
Closed_By Septdir
Labels Added: ?
avatar Septdir Septdir - close - 6 Dec 2017
avatar Septdir
Septdir - comment - 6 Dec 2017

Thank you for your answers, the question is settled.

Add a Comment

Login with GitHub to post a comment