The menu item edit page should render quickly with minimal html and js and certainly not crash because of running out of memory.
Actually you might run out of memory and crash because 'bootstrap.renderModal' is not the least bit scalable.
Doesn't matter.
This feature was just badly implemented in a way that doesn't scale at all. It shouldn't matter how many links to open module editors in modal dialogs you have, you should only need one javascript function to open them all and you should only need one block of html that you can reuse for all modals. This would normally be easy to do but JHtmlBootstrap::renderModal
makes it impossible by using an id as a selector. So the only solution is to not use that function or its accompanying layout. Will this have any implications?
Labels |
Added:
?
|
OK...I found a way to deal with it. The javascript on this page could still be better. Those first four click handlers (I didn't touch) could all be done with one tiny function.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-05 12:55:49 |
Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18979
On top of that, the html for the modals are all written inside of
<tr>
s which is not even valid.