Feeling Lucky
[#18934] - Fixes Custom module's Module Tag option not taking effect.
- Closed
- 2 Dec 2017
- Medium
- Build: staging
- # 18934
- Diff
- jamesfu:patch-1
User tests: Successful: Unsuccessful:
Currently, regardless of which Module tag is selected when creating a Custom module (Custom > Advanced > Module Tag), the <div> tag is always applied. This PR fixes the bug by applying the user-desired HTML tag.
Pull Request for Issue # .
Summary of Changes
Updated hardcoded div tag with $params->get('module_tag')
Testing Instructions
Create a new Custom module, and change Module Tag to something other than div
Expected result
Resultant Custom module should be enclosed in selected tag
Actual result
Resultant Custom module still enclosed in div tag
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
franz-wohlkoenig
- | Status | Pending | ⇒ | Information Required |
jamesfu
- comment
- 2 Dec 2017
Whoops, sorry! Didn't realise the module tags are implemented by chromes, not the module template.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18934.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-02 08:22:15 |
| Closed_By | ⇒ | jamesfu |
Doesnt this depend on the chrome being used for the template position?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18934.