? ? Pending

User tests: Successful: Unsuccessful:

avatar hacki65
hacki65
29 Nov 2017

Pull Request for Issue # .
#18905

Summary of Changes

Reordered menu entries and added seperators (like in Joomla! 3.7). Fix the icon for "Menus".

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar hacki65 hacki65 - open - 29 Nov 2017
avatar hacki65 hacki65 - change - 29 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2017
Category Administration com_menus
avatar infograf768
infograf768 - comment - 30 Nov 2017

Similar to #18908 ?

avatar hacki65
hacki65 - comment - 30 Nov 2017

@infograf768 Yes, similar to #18908, but this fixes more issues in the whole admin menu. Since 3.8 Joomla! has presets for the admin menu and can be changed in the admin menu module.

In order that both presets give same result i have changed both presets. It gives the same ordering (incl. the seperators) for admin menu as it was in J3.7.

In preset "modern.xml" the only change is that the menu entry "Extensions" would be "Manage" with an alternative menu struktur.

Also it fixes the problem with the menu entry "Menus" where the icons for language or home has no space between the string and the icon.

If this PR will be merged, than the other could be closed. But nevertheless thanks to @alikon for his PR.

avatar Quy Quy - test_item - 30 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 30 Nov 2017

I have tested this item successfully on 46a34a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18918.

avatar ladyjer ladyjer - test_item - 30 Nov 2017 - Tested successfully
avatar ladyjer
ladyjer - comment - 30 Nov 2017

I have tested this item successfully on 46a34a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18918.

avatar infograf768
infograf768 - comment - 1 Dec 2017

@izharaazmi
Please check and confirm.

avatar izharaazmi izharaazmi - test_item - 1 Dec 2017 - Tested successfully
avatar izharaazmi
izharaazmi - comment - 1 Dec 2017

I have tested this item successfully on 46a34a8

Looks better now :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18918.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Dec 2017

Ready to Commit after three successful tests.

avatar hacki65
hacki65 - comment - 1 Dec 2017

Thanks for testing, guys.

avatar izharaazmi
izharaazmi - comment - 2 Dec 2017

Space is to add a space between title and icon.

avatar hacki65
hacki65 - comment - 2 Dec 2017

@alikon Yep, a simple, but effective solution. With the original presets the icon for home or language image has no space - in order it is place direct behind the title.

avatar mbabker mbabker - change - 2 Dec 2017
Labels Added: ?
avatar mbabker mbabker - change - 2 Dec 2017
Labels Added: ?
avatar mbabker mbabker - change - 2 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-02 20:14:26
Closed_By mbabker
avatar mbabker mbabker - close - 2 Dec 2017
avatar mbabker mbabker - merge - 2 Dec 2017

Add a Comment

Login with GitHub to post a comment