[#18901] - [4.0] Deprecate Document::getInstance
- Fixed in Code Base
- 16 Feb 2018
- Medium
- Build: 4.0-dev
- # 18901
- Diff
- Digital-Peak:j4/deprecate/document/instance
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Ongoing effort to phase out getInstance code. This pr deprecates Document::getInstance.
I'm splitting #16918 into different pr's to be easier to review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Installation Libraries |
| Status | Pending | ⇒ | Information Required |
Browsing around should be fine. It is more, merge by review.
I have tested this item
Browsed around in Front- and Backend, can't find Error-Message or similar.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.
| Status | Information Required | ⇒ | Pending |
I have tested this item
Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.
Oops, @Quy please remove RTC
And test this by installing a fresh patch. Not by patchtester.
@franz-wohlkoenig
Error 0 Call to a member function get() on null
| Status | Ready to Commit | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.
Where do you get that error? Does it not happen without the patch?
System information
Linux
I'v just opened the page and it worked. Try to download it from here https://github.com/Digital-Peak/joomla-cms/archive/j4/deprecate/document/instance.zip. Not sure why it fails on your server. Enable debug in your configuration.php file, what is the stack trace?
Did you check on Linux? I am not sure but i thing its Linux problem
Here is a stack trace. By enabling Jdebug in installation/includes/framwork.php
| Labels |
Added:
?
|
||
Good catch, forgot to add () on the installer application. Try again please, should be fixed now.
Thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.
OK so by implication of what this PR does there's no longer the ability to create more than one Document instance of a given type. Currently any different config signature would form a new document instance because we serialise the attributes https://github.com/Digital-Peak/joomla-cms/blob/73885b4b51a6705719909e4621431c7a97b8cdd9/libraries/src/Document/Document.php#L327
this is probably fine - but can anyone think of any use cases in the system where we exploit this?
Also has anyone tested the non-html views for this - the contact ecard, the xml and feed views etc?
VCard worked
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-16 23:02:55 |
| Closed_By | ⇒ | wilsonge |
how can this be tested? By "browse around in the Front- and Backend"?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18901.