Feeling Lucky
?
[#18892] - 'Page Class' echoed as page class suffix
- Closed
- 4 Dec 2017
- Medium
- Build: staging
- # 18892
Steps to reproduce the issue
Most of the core components echos the 'Page Class' in the containing div of the component. In every case the class is echoed as a class suffix (https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/article/tmpl/default.php#L27) rather than a standalone class which the 'Page Class' field implies .
I would question if this class should even be echoed here. Its name implies (to me at least) that it should be echoed as a class on the body tag?
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | Code style |
| Status | New | ⇒ | Information Required |
rgmears
- comment
- 29 Nov 2017
Adding the page class to the body tag is where it belongs. Doing so allows for changing the appearance of whole pages without having to use a different template. I describe how to do it here: http://www.j-tutor.studiofive.biz/elements/template
wilsonge
- | Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-04 00:36:51 |
| Closed_By | ⇒ | wilsonge |
I agree, it’s a page class not a container class or suffix.
Problem we have now is to remove it is a BC since users may be using it in their CSS.
Would say we remove this for J4?