[#18881] - Tag and bracket completion and matching bug
- Fixed in Code Base
- 16 Jan 2018
- Medium
- Build: staging
- # 18881
- Diff
- okonomiyaki3000:CodeMirror-FixTagMatching
User tests: Successful: Unsuccessful:
This fixes a bug where the tag/bracket completion and matching settings are not applied. This bug was introduced in a recent change to this plugin which moved the mode selection logic from php to javascript. So it's my fault.
Pull Request for Issue # .
Summary of Changes
Stop expecting the mode to be something like 'htmlembbed' or 'htmlmixed' and just expect 'html'.
Testing Instructions
Make sure the tag or bracket matching and completion options are turned on in the codemirror plugin. Use codemirror to write some html or maybe javascript or css.
Expected result
Your tags and brackets should be autocompleted and/or matched (when the cursor is on one, it's match should be highlighted).
Actual result
This was not working in html documents (articles, etc).
Documentation Changes Required
No, it's just a fix for a recently introduced bug. With any luck, no one will notice it ever happened.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18881.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18881.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-16 22:40:44 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
This is an actual fix for an actual bug.