[#18872] - [4.0] Replace BS alerts with CE alerts
- Fixed in Code Base
- 6 Dec 2017
- Medium
- Build: 4.0-dev
- # 18872
- Diff
- C-Lodder:alerts-all
User tests: Successful: Unsuccessful:
Summary of Changes
This PR replaces all Bootstrap alerts (apart from the installation views) with custom elements (<joomla-alert>)
It also addresses the issue: #18849
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate |
| Labels |
Added:
?
|
||
There are a few of the following. Should they be updated too?
<p class="alert alert-info">
ah yes, didn't realise some were initiated with a <p> tag. Will do that in a bit
Also in Atum template files. Here is one.
https://github.com/C-Lodder/joomla-cms/blob/564592a05552c9954d3589df7f828339a4ac9cd2/administrator/templates/atum/error.php#L70
In .xml file, when alert is specified in the class attribute:
<field
name="warning"
type="note"
label="COM_TEMPLATES_CONFIG_SUPPORTED_LABEL"
default="zip"
extension="com_templates"
class="alert alert-info"
/>
here is the output not using CE alert:
<div class="alert alert-info"><h4>Supported File Formats</h4> </div>
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18872.
This conflicts with the PR I merged earlier - if you get conflicts sorted will get this merged :)
Le fixed
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-06 09:22:56 |
| Closed_By | ⇒ | wilsonge |
Thankyou :)
Update:
https://github.com/C-Lodder/joomla-cms/blob/9601280e99f413e4d8607e458e553cba1dba70b2/administrator/components/com_modules/tmpl/module/edit_assignment.php#L115