[#18866] - [4.0] Select Bootstrap size for modules
- Closed
- 2 Dec 2017
- Medium
- Build: 4.0
- # 18866
Steps to reproduce the issue
Create a couple of custom modules and assign to the same position (Footer is as good as any)
Under the advanced tab change the module size using the Bootstrap Size selector.
Expected result
modules should display in a row with the correct size selected from the dropdown
html output is class="col-3" (if the size selected was 3
Actual result
html output is class="span3" (if the size selected was 3
System information (as much as possible)
Joomla 4Alpha
xammp
Additional comments
I believe that https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/system/html/modules.php line 28 needs updating from
[code]$moduleClass = $bootstrapSize !== 0 ? ' span' . $bootstrapSize : '';[/code]
to
[code]$moduleClass = $bootstrapSize !== 0 ? ' col-' . $bootstrapSize : '';[/code]
I am not sure if this is the only change that's needed, if so I am happy to open a PR
| Status | New | ⇒ | Discussion |
Thanks for the responses, I presume this can be closed when there is a PR for the removal of the Bootstrap size box.
@ciar4n I am having a look at #18516 now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18866.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 10:06:21 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18866
closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18866.
@franz-wohlkoenig we don't have a PR for the removal of the bootstrap size yet.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18866.
Re-opening.
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-11-26 10:06:21 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
Personally, I would do it the same in front- and backend. I don't see a reason to differentiate. If the reason is the different template architecture from front- and backend, then think a second time about it
| Status | New | ⇒ | Discussion |
Cool. Will finish off PR tomorrow
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-02 15:04:43 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18866
The parameter would need to be recognised by the template (Cassiopeia) module chromes as well, But to my knowledge it got stripped out. The parameter likely gets removed completely.
I haven't tried yet, but I think you should be able to write the class as a module class (suffix) and get the same result.