? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Nov 2017

Revert three strings

PR for #18858

avatar brianteeman brianteeman - open - 25 Nov 2017
avatar brianteeman brianteeman - change - 25 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2017
Category Administration Language & Strings
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Nov 2017

I have tested this item successfully on 34100c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18862.

avatar infograf768
infograf768 - comment - 26 Nov 2017

Is also missing an important tip (among others) that was present in en-GB.com_categories.sys.ini
COM_CATEGORIES_CHOOSE_COMPONENT_DESC="Select a component to which this category should be linked. <br />If a component using categories is not shown in the list, please create at least one category for it using the default regular menu."
Description missing in the extension field in /administrator/components/com_categories/tmpl/categories/default.xml

We have
screen shot 2017-11-26 at 09 22 55

We should have
screen shot 2017-11-26 at 09 30 05

avatar infograf768
infograf768 - comment - 26 Nov 2017

Although the tip should be modified a bit (this category looks wrong as well in 3.8) as it works fine for "Create a New Category" but not for "List all categories'

avatar infograf768 infograf768 - test_item - 26 Nov 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Nov 2017

I have tested this item successfully on 34100c5

As it can be considered as a separate issue. I added a my test as succesful


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18862.

avatar infograf768
infograf768 - comment - 26 Nov 2017

@izharaazmi
Can you look into that specific tip for staging?

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Nov 2017

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 26 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-26 22:47:36
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Nov 2017
avatar wilsonge wilsonge - merge - 26 Nov 2017
avatar wilsonge
wilsonge - comment - 26 Nov 2017

Thanks :)

avatar brianteeman
brianteeman - comment - 26 Nov 2017

thanks

avatar izharaazmi
izharaazmi - comment - 28 Nov 2017

@infograf768 I checked these keys are present in staging. What else you want me to check?

avatar infograf768
infograf768 - comment - 28 Nov 2017

@izharaazmi
It looks like COM_CATEGORIES_CHOOSE_COMPONENT_DESC is used both for
Create New Category and List All Categories.
The value is fine for the first one, but not for the second one.

Add a Comment

Login with GitHub to post a comment