Feeling Lucky
?
[#18856] - [CS] Code Style fixes for administrator/components/com_newsfeeds/
- Fixed in Code Base
- 26 Nov 2017
- Medium
- Build: staging
- # 18856
- Diff
- photodude:PHPCS2-com_newsfeeds
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Expected 1 newline after opening brace
- Blank line found at start of control structure
- No blank line found before/after control structure
- Whitespace found at end of line
- Closing parenthesis of a multi-line function call must be on a line by itself
- Expected "boolean" but found "bool" for function return type
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_newsfeeds |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 23:04:44 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on b2af089
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18856.