? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
24 Nov 2017

Pull Request for Issue code style fixes

Summary of Changes

  • Expected 1 newline after opening brace
  • Blank line found at start of control structure
  • No blank line found before/after control structure
  • Whitespace found at end of line
  • Closing parenthesis of a multi-line function call must be on a line by itself
  • Expected "boolean" but found "bool" for function return type

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

avatar photodude photodude - open - 24 Nov 2017
avatar photodude photodude - change - 24 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2017
Category Administration com_newsfeeds
avatar Quy Quy - test_item - 24 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 24 Nov 2017

I have tested this item successfully on b2af089


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18856.

avatar wilsonge wilsonge - change - 26 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-26 23:04:44
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Nov 2017
avatar wilsonge wilsonge - merge - 26 Nov 2017

Add a Comment

Login with GitHub to post a comment