Feeling Lucky
?
[#18851] - [CS] Code Style fixes for administrator/components/com_menus/
- Fixed in Code Base
- 26 Nov 2017
- Medium
- Build: staging
- # 18851
- Diff
- photodude:PHPCS2-com_menus
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Blank line found at end of control structure
- Blank line found at start of control structure
- No blank line found after control structure
- Expected "array|boolean" but found "array|bool" for function return type
- Expected "integer" but found "int" for function return type
- Closing parenthesis of a multi-line function call must be on a line by itself
- Multi-line function call not indented correctly
- Expected 1 newline after opening brace
- Tabs must be used to indent lines; spaces are not allowed
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style check on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 23:01:09 |
| Closed_By | ⇒ | wilsonge |