Feeling Lucky
?
[#18847] - [CS] Code Style fixes for administrator/components/com_media/
- Fixed in Code Base
- 26 Nov 2017
- Medium
- Build: staging
- # 18847
- Diff
- photodude:PHPCS2-com_media
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Line indented incorrectly;
- Logical operator "or" not allowed; use "||" instead
- No blank line found after control structure
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style check on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
alikon
- comment
- 24 Nov 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18847.
alikon
- comment
- 24 Nov 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18847.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 24 Nov 2017
Ready to Commit after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 23:01:42 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 24c12a9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18847.