Feeling Lucky
?
[#18842] - [CS] Code Style fixes for administrator/components/com_login/
- Fixed in Code Base
- 26 Nov 2017
- Medium
- Build: staging
- # 18842
- Diff
- photodude:PHPCS2-com_login
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Tabs must be used to indent lines; spaces are not allowed
- Whitespace found at end of line
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_login |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 23:03:24 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 26 Nov 2017
@photodude might be worth updating your link to this file in your squizlabs/PHP_CodeSniffer#1760 to point to the 3.8.2 tag :)
I have tested this item✅ successfully on 1e0dbb5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18842.