[#18836] - Fix copy paste in docs
- Fixed in Code Base
- 2 Dec 2017
- Medium
- Build: staging
- # 18836
- Diff
- brianteeman:copypaste
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
If we have doc blocks then they should be correct
The property name for which to the the value
==>
The property name for which to set the value
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_menus Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18836.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
not quite ready for RTC
needs a dev to answer if it is set or get
| Status | Ready to Commit | ⇒ | Pending |
Status back on "Pending".
As noted, Should be get for the get method and set for the set method.
Thanks for that review - I will make all the edits tonight
| Labels |
Added:
?
|
||
Should be good to go now
I have tested this item
Looks good by code review now that set is set and get is get
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18836.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18836.
@franz-wohlkoenig RTC please
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Thanks for Tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-02 20:18:14 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 0b60040
Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18836.